anmode / grabtern-frontend

Connecting the mentors and creating a network
https://grabtern.in/
MIT License
22 stars 35 forks source link

FEATURE: Dark mode #804

Closed vatsalsinghkv closed 10 months ago

vatsalsinghkv commented 10 months ago

Related Issue

Implementation of dark mode

Closes: #778

Description of Changes

Checklist:

Screenshots

Original Updated
Original screenshot Updated screenshot
vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grabtern-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 4:30am
github-actions[bot] commented 10 months ago

Thank you, @vatsalsinghkv, for creating this pull request and contributing to GitHub-ReadMe! Our review team will thoroughly review the pull request and will reach out to you soon! Please make sure you have marked all the completed tasks as done. We appreciate your patience and contribution!

anmode commented 10 months ago

Nice to see this pR: Firstly we need to have light theme on default Some minor UI issues needs to fixed:

Screenshot 2023-11-03 at 11 09 32 AM Screenshot 2023-11-03 at 11 09 57 AM

and try to login into dashboard see for UI in dark mode there.... Rest all is good!

vatsalsinghkv commented 10 months ago

@anmode what do you think we invert this image in the dark mode?

Screenshot 2023-11-03 at 4 15 40 PM
vatsalsinghkv commented 10 months ago

@anmode I've tried to login but i didn't get verification email, do you have any testing login credentials for me to test out the dashboard

anmode commented 10 months ago

@anmode I've tried to login but i didn't get verification email, do you have any testing login credentials for me to test out the dashboard

please see readme... all dev emails goes to ethereal. you can find credentials to login into ethereal from readme! and yeah invert image look good!

vatsalsinghkv commented 10 months ago

@anmode is there a way to run google auth through the backend endpoints given in the .env, I tried loging in manually it didn't work got internal server error. But I fixed more pages like reset password, mentor registration pages to the darkmode in the last commit

anmode commented 10 months ago

@anmode is there a way to run google auth through the backend endpoints given in the .env, I tried loging in manually it didn't work got internal server error. But I fixed more pages like reset password, mentor registration pages to the darkmode in the last commit

if you want to login , through email you can login in dev mode but can't use google auth. Due to security purpose we can't to out the client ID. no worries you can create account!

wait please give me. your credentials which you created for your grabtern dev account?

vatsalsinghkv commented 10 months ago

@anmode sure, we can implement dark-mode on dashboard in the next PR, I think I've made the default theme as light in last commit, test it by deleting darkMode from local storage and refresh the page. Also while implementing dark-mode I've seen some UI visual errors should I fix them under this PR or should I create another issue for it?

anmode commented 10 months ago

Ok you can create next PR!.. can you give me your credentials so i can check what causing err to create grabtern account?

vatsalsinghkv commented 10 months ago

@anmode My account is working with production server, but with the demo server I am unable to login, it usually says my account is registered and password don't match. It while resetting it gives a server error, can you try creating an account and resetting its password with the demo server?

My credentials were: email: vatsalsinghkv@gmail.com password: i dont know or idontknow

anmode commented 10 months ago

oh yeah i see actually demo backend was not updated with mainstream so it ws causing the issue... so i fixed, your password is idontknow I see some pages needs rework in , i think you are mentioning those UI fix.. one main is loader in darkmode will be differenct.