Closed rishuraj1 closed 11 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
grabtern-frontend | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 5, 2023 3:57pm |
Thank you, @rishuraj1, for creating this pull request and contributing to GitHub-ReadMe! Our review team will thoroughly review the pull request and will reach out to you soon! Please make sure you have marked all the completed tasks as done. We appreciate your patience and contribution!
can we give option to skip tour?? but publish profile one is neccessary!
can we give option to skip tour?? but publish profile one is neccessary!
the skip tour option is already given as cross button on the top right of the dialog box, and I don't think that we will be able to show only one step...but I will see again.
can we give option to skip tour?? but publish profile one is neccessary!
the skip tour option is already given as cross button on the top right of the dialog box, and I don't think that we will be able to show only one step...but I will see again.
oh ok my bad!
@anmode I might need some help as I am facing difficulties storing the state and displaying the tour according to it.
So, when a user or mentor logs in to the dashboard the tour
is displayed and the userTour
(in case of user) and mentorTour
(in case of a mentor) variables are saved with value true
. So when we reload the page the tour doesn't show up again.... But when user/mentor logs out and re logs in, again the tour is displayed.
@anmode I might need some help as I am facing difficulties storing the state and displaying the tour according to it.
So, when a user or mentor logs in to the dashboard the
tour
is displayed and theuserTour
(in case of user) andmentorTour
(in case of a mentor) variables are saved with valuetrue
. So when we reload the page the tour doesn't show up again.... But when user/mentor logs out and re logs in, again the tour is displayed.
i got it! during logout the localStorage got erased so we have to make it not to erase...
@anmode I might need some help as I am facing difficulties storing the state and displaying the tour according to it.
So, when a user or mentor logs in to the dashboard the
tour
is displayed and theuserTour
(in case of user) andmentorTour
(in case of a mentor) variables are saved with valuetrue
. So when we reload the page the tour doesn't show up again.... But when user/mentor logs out and re logs in, again the tour is displayed.
i got it! during logout the localStorage got erased so we have to make it not to erase...
@anmode , I am sorry Anmol I don't get it so can you please fix that.
@anmode , I am sorry Anmol I don't get it so can you please fix that.
haaa no wories i'll do that...I hp tour is mobile optimized. however you can create final PR for all dashboard fix you might encounter! it would be great if you can test by creating a mentor account and using your dashboard thanks!
Related Issue
Closes: #799
Description of Changes
Checklist:
Screenshots
https://github.com/anmode/grabtern-frontend/assets/47839626/cca5134b-fd52-43c9-bb7e-235aa7146f49
https://github.com/anmode/grabtern-frontend/assets/47839626/bb4181a2-d778-4f99-ba51-79f0ace79728
Please provide any necessary screenshots to illustrate the changes made.