anmode / grabtern-frontend

Connecting the mentors and creating a network
https://grabtern.in/
MIT License
22 stars 35 forks source link

feat: Dashboard tour for users and mentors in mobile view #807

Closed rishuraj1 closed 10 months ago

rishuraj1 commented 10 months ago

Related Issue

followup: #806

Description of Changes

Checklist:

Screenshots

image

image

image

image

image

@anmode

Please provide any necessary screenshots to illustrate the changes made.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grabtern-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 4:36pm
github-actions[bot] commented 10 months ago

Thank you, @rishuraj1, for creating this pull request and contributing to GitHub-ReadMe! Our review team will thoroughly review the pull request and will reach out to you soon! Please make sure you have marked all the completed tasks as done. We appreciate your patience and contribution!

anmode commented 10 months ago

All looks good Rishu, here are some couple fixes it would be great if you can complete this in PR ( last PR to get merge for swagkit) You have done many descent contribution to grabtern. we are very greatful :)

  1. pending and completed both!

    Screenshot 2023-11-07 at 1 23 54 PM

    this need to be fixed in desktop and mobile view

  2. We need to implement a frontend button in session ( so mentor can delete the session too, backend is prepared and here is the funtcion too you just need to create a button

    Screenshot 2023-11-07 at 1 28 00 PM
const deleteSession = async function (sessionID) {
    try {
      setLoadingState({ status: true });
      setErrorState({ status: false });

      // Show a confirmation dialog
      const confirmed = window.confirm("Are you sure you want to delete this session?");

      if (!confirmed) {
        // User canceled the deletion
        setLoadingState({ status: false });
        return;
      }

      const url = `${process.env.NEXT_PUBLIC_BACKEND_URL}/api/mentors/deleteListedSession/${sessionID}`;
      const response = await axios.delete(url, { withCredentials: true });

      fetchData();
      setLoadingState({ status: false });
    } catch (error) {
      setLoadingState({ status: false });
      if (
        error.response &&
        error.response.status >= 400 &&
        error.response.status <= 500
      ) {
        setErrorState({ status: true, message: error.response.data.message });
      } else {
        setErrorState({ status: true });
      }
    }
  };
  1. Edit form session needs some icons!
rishuraj1 commented 10 months ago

sure, will do it by tonight

anmode commented 10 months ago

Cool !

rishuraj1 commented 10 months ago

@anmode I am thinking of creating another new table component to display the data, because the UI will break at some point and can't be done using css only. we can use packages like tanstack react table to implement this, since it will take time, I will do it in the next PR. Now I have done all the changes requested. additionally, added cancel button to the add and edit session forms.

Screenshot 2023-11-07 161019 Screenshot 2023-11-07 160407

https://github.com/anmode/grabtern-frontend/assets/47839626/f81b75c2-6ba6-41e6-87b3-cd611c8f7f9d

anmode commented 10 months ago

@anmode I am thinking of creating another new table component to display the data, because the UI will break at some point and can't be done using css only. we can use packages like tanstack react table to implement this, since it will take time, I will do it in the next PR. Now I have done all the changes requested. additionally, added cancel button to the add and edit session forms.

Screenshot 2023-11-07 161019 Screenshot 2023-11-07 160407 GrabTern._.Grab.Your.Internship.-.Brave.2023-11-07.16-22-47.mp4

totally agreed! Wow all things looks good.. I'll merge after testing today for sure!

anmode commented 10 months ago
Screenshot 2023-11-07 at 9 24 00 PM

Small issue chat bot is over riding the more button , 1.This issue needs to be fixed and please could you align the items in more option and one fix here is that when we click on any tab in more , the more popup do not closes automatically.

Rest all seems fine

rishuraj1 commented 10 months ago

@anmode these changes should do the fix.

https://github.com/anmode/grabtern-frontend/assets/47839626/c57465ce-fa28-4355-9ed6-5b9edaaffd27