Closed ChiragSinghal2001 closed 2 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
grabtern-frontend | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 29, 2024 5:10am |
Thank you, @ChiragSinghal2001, for creating this pull request and contributing to GitHub-ReadMe! Our review team will thoroughly review the pull request and will reach out to you soon! Please make sure you have marked all the completed tasks as done. We appreciate your patience and contribution!
note: we have to create an API for updating, and creating job posts. We will have the UI in the admin dashboard.
One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have index.js
in place of [jobID].page.js
?
One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have
index.js
in place of[jobID].page.js
?
we can create something like ([...params].js) to catch all routes if dynamic params increase .
note: we have to create an API for updating, and creating job posts. We will have the UI in the admin dashboard.
The API to create job posts has already been added to the backend.
One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have
index.js
in place of[jobID].page.js
?we can create something like ([...params].js) to catch all routes if dynamic params increase .
Umm.. this needs to be rethink. Let's connect to have discussion over this!
One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have
index.js
in place of[jobID].page.js
?we can create something like ([...params].js) to catch all routes if dynamic params increase .
Umm.. this needs to be rethink. Let's connect to have discussion over this!
Sure
Changes in UI in new commit
Some last small fix: 1. In case of no job do not show the header of the page ( which is open position...)( does not look )
black color looks very odd ( white would be good)
Some last small fix: 1. In case of no job do not show the header of the page ( which is open position...)( does not look ) 2. black color looks very odd ( white would be good)
okk sure
Some last comment.. Nd is it mobile responsive?
yes it is
UI is improved and a new page added
@ChiragSinghal2001 cool, Really amazing thanks for making this 🚀 . Please make sure to take it down your API key as this repo is open-source. We will create our own API key.
Related Issue
Closes: #[issue number]
Description of Changes
Checklist:
Screenshots
Please provide any necessary screenshots to illustrate the changes made.