anmode / grabtern-frontend

Connecting the mentors and creating a network
https://grabtern.in/
MIT License
27 stars 49 forks source link

Career Page #838

Closed ChiragSinghal2001 closed 2 months ago

ChiragSinghal2001 commented 2 months ago

Related Issue

Closes: #[issue number]

Description of Changes

Checklist:

Screenshots

Original Updated
Original screenshot Updated screenshot

Please provide any necessary screenshots to illustrate the changes made.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grabtern-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 5:10am
github-actions[bot] commented 2 months ago

Thank you, @ChiragSinghal2001, for creating this pull request and contributing to GitHub-ReadMe! Our review team will thoroughly review the pull request and will reach out to you soon! Please make sure you have marked all the completed tasks as done. We appreciate your patience and contribution!

ChiragSinghal2001 commented 2 months ago
1 2
anmode commented 2 months ago

note: we have to create an API for updating, and creating job posts. We will have the UI in the admin dashboard.

anmode commented 2 months ago

One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have index.js in place of [jobID].page.js?

ChiragSinghal2001 commented 2 months ago

One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have index.js in place of [jobID].page.js?

we can create something like ([...params].js) to catch all routes if dynamic params increase .

ChiragSinghal2001 commented 2 months ago

note: we have to create an API for updating, and creating job posts. We will have the UI in the admin dashboard.

The API to create job posts has already been added to the backend.

anmode commented 2 months ago

One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have index.js in place of [jobID].page.js?

we can create something like ([...params].js) to catch all routes if dynamic params increase .

Umm.. this needs to be rethink. Let's connect to have discussion over this!

ChiragSinghal2001 commented 2 months ago

One important to note: in future may be we will passing more URL params as refer id.. how we will handling those? Is it possible to handle that via using page routing. can we simple have index.js in place of [jobID].page.js?

we can create something like ([...params].js) to catch all routes if dynamic params increase .

Umm.. this needs to be rethink. Let's connect to have discussion over this!

Sure

ChiragSinghal2001 commented 2 months ago
5 6 7 8

Changes in UI in new commit

anmode commented 2 months ago

Some last small fix: 1. In case of no job do not show the header of the page ( which is open position...)( does not look )

  1. Screenshot 2024-07-26 at 9 05 23 PM

    black color looks very odd ( white would be good)

ChiragSinghal2001 commented 2 months ago

Some last small fix: 1. In case of no job do not show the header of the page ( which is open position...)( does not look ) 2. Screenshot 2024-07-26 at 9 05 23 PM black color looks very odd ( white would be good)

okk sure

ChiragSinghal2001 commented 2 months ago

Some last comment.. Nd is it mobile responsive?

yes it is

ChiragSinghal2001 commented 2 months ago
11 12 13 14

UI is improved and a new page added

anmode commented 2 months ago

@ChiragSinghal2001 cool, Really amazing thanks for making this 🚀 . Please make sure to take it down your API key as this repo is open-source. We will create our own API key.