search

anmol098 / waka-readme-stats

This GitHub action helps to add cool dev metrics to your github profile Readme
MIT License
3.39k stars 555 forks source link

Fixed `TypeError` when commit is being null. #464

Open AyushAgnihotri2025 opened 1 year ago

AyushAgnihotri2025 commented 1 year ago

Closes #463 Closes #425

willnaoosmith commented 1 year ago

Merging when?

pseusys commented 7 months ago

I personally can't merge the PR until the CI workflow runs successfully and I also can't launch the workflow. I think, it should be triggered on push. @AyushAgnihotri2025, @willnaoosmith, could you please make sure the workflow runs successfully and, if not, investigate logs and fix errors?

P.S. also, if it's not a big deal, I would prefer if commit is not None: syntax as it is more explicit and clear.

willnaoosmith commented 7 months ago

@pseusys it finally did run correctly again! @AyushAgnihotri2025 Thanks for the help!