search

anmonteiro / aws-lambda-ocaml-runtime

An OCaml custom runtime for AWS Lambda and Vercel
BSD 3-Clause "New" or "Revised" License
207 stars 8 forks source link

Fixes Issue #42 (build script fails) #43

Closed superherointj closed 5 years ago

superherointj commented 5 years ago

https://github.com/anmonteiro/aws-lambda-ocaml-runtime/issues/42

anmonteiro commented 5 years ago

Thanks for this -- would you mind adding it to every Dockerfile in the examples folder?

superherointj commented 5 years ago

Sure. I'll test all examples. And send patch for each.

anmonteiro commented 5 years ago

I really appreciate that -- you may have to bump the esy versions in the Dockerfile to 0.5.8 or @latest

superherointj commented 5 years ago

Can I set every example dependency to use @latest (docker images, packages, ocaml, esy, etc)? I prefer that behavior because software gets outdated quickly. And if it breaks we can always fix it.

anmonteiro commented 5 years ago

Yeah I think that's fine

superherointj commented 5 years ago

I tried to use git commit but I did not have permission. Then I tried to paste the patch here but GitHub did not accept. So I zipped it. I hope you'll be able to apply it. Sorry for the inconvenience.

patch-coreutils.zip

superherointj commented 5 years ago

https://github.com/superherointj/aws-lambda-ocaml-runtime/commit/1d1cfc69a66fb6029084c2af8d982492186b6aa2

anmonteiro commented 5 years ago

can you open a new PR from that commit?

superherointj commented 5 years ago

Done. https://github.com/anmonteiro/aws-lambda-ocaml-runtime/pull/44