search

anmonteiro / aws-lambda-ocaml-runtime

An OCaml custom runtime for AWS Lambda and Vercel
BSD 3-Clause "New" or "Revised" License
207 stars 8 forks source link

tolerate unknown fields #62

Closed joprice closed 2 years ago

joprice commented 2 years ago

strict mode was not disabled for api_gateway_request_identity, so some new fields like cognitoAmr are causing body parsing to fail.

anmonteiro commented 2 years ago

Thanks!

joprice commented 2 years ago

@anmonteiro The nix build failed. I saw something similar before with cachix action being outdated, so I pushed a commit with updated cachix version to at least rule that out.

joprice commented 2 years ago

I'm not seeing mismatched hashes for menhir. I'm assuming that 

         specified: sha256:168qd2r6aiic2l5n7gxx085avx3afsrs2vjgwzmkkayix4nak5pf
         got:       sha256:1nsw5qzax4qdj1i0ijbrqwa5frivrq2laqkq88d402cb82dxp85g

I tried updating the overlays in nix/sources.nix, but got an interesting new error:

error: attempt to call something which is not a function but a string with context
anmonteiro commented 2 years ago

I updated it recently, you need to use boot.nix instead of sources.nix

anmonteiro commented 2 years ago

@joprice don't worry about CI for now, I'll fix it soon.

joprice commented 2 years ago

It at least builds and dune test passes locally in nix-shell with my latest commit.