anmonteiro / httpun-ws

Other
27 stars 14 forks source link

File "eio/gluten_eio.ml", line 132, characters 16-22: Assertion failed #65

Closed copy closed 4 months ago

copy commented 4 months ago

Running the echo server example and connecting with chromium's built-in websocket, we get:

dune exec examples/eio/echo_server.exe
Fatal error: exception File "examples/eio/echo_server.ml", line 71, characters 65-71: Assertion failed

Replacing on_error:(fun _ -> assert false) with on_error:(fun e -> raise e) then yields:

Fatal error: exception File "lib/server_connection.ml", line 81, characters 4-10: Assertion failed

Finally, by replacing that assert false with a raise exn the error becomes:

Fatal error: exception File "eio/gluten_eio.ml", line 132, characters 16-22: Assertion failed
copy commented 4 months ago

Nevermind, I was using wss:// 🤦

anmonteiro commented 4 months ago

Thanks for the report. I still think this is an issue insofar as you hit an assert false where we should likely fall through to closing the connection