Closed copy closed 4 months ago
Running the echo server example and connecting with chromium's built-in websocket, we get:
dune exec examples/eio/echo_server.exe Fatal error: exception File "examples/eio/echo_server.ml", line 71, characters 65-71: Assertion failed
Replacing on_error:(fun _ -> assert false) with on_error:(fun e -> raise e) then yields:
on_error:(fun _ -> assert false)
on_error:(fun e -> raise e)
Fatal error: exception File "lib/server_connection.ml", line 81, characters 4-10: Assertion failed
Finally, by replacing that assert false with a raise exn the error becomes:
assert false
raise exn
Fatal error: exception File "eio/gluten_eio.ml", line 132, characters 16-22: Assertion failed
Nevermind, I was using wss:// 🤦
Thanks for the report. I still think this is an issue insofar as you hit an assert false where we should likely fall through to closing the connection
Running the echo server example and connecting with chromium's built-in websocket, we get:
Replacing
on_error:(fun _ -> assert false)
withon_error:(fun e -> raise e)
then yields:Finally, by replacing that
assert false
with araise exn
the error becomes: