anmonteiro / httpun

A high performance, memory efficient, and scalable web server written in OCaml
Other
50 stars 11 forks source link

httpun-eio failing to build #131

Closed ada2k closed 5 months ago

ada2k commented 5 months ago

This commit changed a type of create_connection from Eio_unix.Net.stream_socket_ty Eio.Net.stream_socket to _ Eio.Net.stream_socket. This results, at least in a fresh 5.2.0 switch on my dev machine, in httpun-eio failing to build:

# Error: The implementation "eio/httpun_eio.ml"
# [...]
#             | `Flow
#             | `Platform of 'b
#             | `R
#             | `Shutdown
#             | `Socket
#             | `Stream
#             | `W ]"
#        The second variant type is open and the first is not
#        File "eio/httpun_eio.mli", lines 53-57, characters 2-8:
#          Expected declaration
#        File "eio/httpun_eio.ml", line 64, characters 6-23: Actual declaration
anmonteiro commented 5 months ago

You need gluten 0.5.1, pending merge on opam-repo

anmonteiro commented 5 months ago

https://github.com/ocaml/opam-repository/pull/26018

ada2k commented 5 months ago

Thank you!