anmonteiro / lumo

Fast, cross-platform, standalone ClojureScript environment
Eclipse Public License 1.0
1.88k stars 84 forks source link

package.json is missing `opencollective` as a dependency. #409

Closed johanatan closed 6 years ago

johanatan commented 6 years ago

title says it all.

anmonteiro commented 6 years ago

opencollective shouldn't be a dependency of the installed Lumo binary.

What is this issue about? can you provide more context?

anmonteiro commented 6 years ago

FWIW it's a devDependency in the top-level package.json: https://github.com/anmonteiro/lumo/blob/master/package.json#L55

This is, however, a "private" package.json that is not part of the published NPM package.

johanatan commented 6 years ago

Post-install script fails during install of lumo-cljs via npm install -g lumo-cljs in the ubuntu codebuild environment on AWS.

[This also happens when installing closh which is based on lumo].

anmonteiro commented 6 years ago

@johanatan there's no postinstall script (https://github.com/anmonteiro/lumo/blob/master/packages/lumo/package.json) in the published Lumo package.

anmonteiro commented 6 years ago

Please note that trying to install Lumo from master doesn't really work (i.e. npm install github:anmonteiro/lumo or somesuch)

johanatan commented 6 years ago

Oh, sorry. This is when installing 1.9.0-alpha from a git tag:

npm install anmonteiro/lumo#1.9.0-alpha for example.

johanatan commented 6 years ago

[And I'm trying to install 1.9.0-alpha because of the corrupted zip problem].

anmonteiro commented 6 years ago

Yeah that doesn't work. I'll go ahead and publish 1.9.0-alpha on NPM which I didn't yet.

johanatan commented 6 years ago

Ok, in this case, can you please release the corrupted zip fix to npm?

johanatan commented 6 years ago

Thank you.

anmonteiro commented 6 years ago

Done! Closing.