anmonteiro / lumo

Fast, cross-platform, standalone ClojureScript environment
Eclipse Public License 1.0
1.88k stars 85 forks source link

Repl outputs some hidden chars somehow #99

Closed arichiardi closed 7 years ago

arichiardi commented 7 years ago

Hi Antonio,

I know this report is very vague, but you can observe here that maybe some escape character, maybe due to the highlight, is off. Inf-clojure can understand ANSI colors the output and it does, but the format of these characters is not valid for it. Again, I am not an expert in the area therefore I am not sure.

2017-03-05-194935_342x149_scrot

At the moment inf-clojure strips out the characters, but I wanted to open an issue because it might probably better to fix it here, if somebody has some suggestion on how to.

Thanks!

arichiardi commented 7 years ago

This is related to the node readline it seems:

http://stackoverflow.com/questions/21785955/messed-up-progress-bars-when-installing-npm-packages-inside-ansi-term

https://github.com/nodejs/node-v0.x-archive/issues/5344

So it seems that I can simply use the -d option for solving this problem.

anmonteiro commented 7 years ago

This is still a bug. We should not output escape characters to the socket repl output

arichiardi commented 7 years ago

Just to clarify, this does not happen with socket repl according to my experience.

anmonteiro commented 7 years ago

Wait, so you don't need the socket REPL tonconnect to inf-clojure?!

arichiardi commented 7 years ago

Nope, the socket is just a convenience , the inf- modes are usually used to send to input and read from output descriptors.

anmonteiro commented 7 years ago

start Lumo with --dumb in inf-clojure, or TTY escape codes will be output