JSC_CONSTANT_NOT_ASSIGNED_STRING_LITERAL_ERROR when building with :advanced compilation

anmonteiro / plomber

Component instrumentation for Om Next

Eclipse Public License 1.0

9 stars 2 forks source link

JSC_CONSTANT_NOT_ASSIGNED_STRING_LITERAL_ERROR when building with :advanced compilation #3

Open matthavener opened 7 years ago

matthavener commented 7 years ago

Issue is near this line

https://github.com/anmonteiro/plomber/blob/d985632805a47c6659c9ab53e750f1c176254fca/src/main/plomber/core.cljs#L256

Error from cljsbuild

ERROR: JSC_CONSTANT_NOT_ASSIGNED_STRING_LITERAL_ERROR. Function argument is a variable stats$$8 which is not a constant assigned from a string literal at /work/resources/public/js/compiled/out/plomber/core.js line 994 : 38

Const.from documentation indicates it should only be called on a plain literal

anmonteiro commented 7 years ago

we probably wanna do something like https://github.com/adzerk-oss/boot-reload/commit/dd68f0835c5bbe2dd55492d1dabbe6b3b477b2d3