Closed elenlefoll closed 1 week ago
Also, I wanted to point out that the title of your JOSS paper is potentially misleading: "densify: An R package to prune sparse data frames of typological linguistic data" as, to me, the construction "to prune X of Y" means to get rid of Y. In other words, the title sounds as if {densify} can be used to remove typological linguistic data from sparse data frames.
Hello! Regarding your error, have you tried simply installing the bookdown package?
install.packages("bookdown") remotes::install_github('annagraff/densify', build_vignettes = TRUE)
Regarding the title - happy to put that on the list of things to update!
Yes, after manually installing bookdown, the installation works.
The first "demo" command in the paper returns a warning message for me. Is it intended?
> example_result <- densify(data = WALS,
+ taxonomy = glottolog_languoids,
+ taxon_id = "Glottocode",
+ density_mean = "log_odds",
+ min_variability = 3,
+ limits = list(min_coding_density = 1),
+ density_mean_weights = list(coding = 1, taxonomy = 1))
Warning message:
In densify(data = WALS, taxonomy = glottolog_languoids, taxon_id = "Glottocode", :
! in `densify()`: no `cols` argument specified,
using all columns as variables
ℹ use `cols = <tidy column spec>` to silence
this warning
I was able to tick nearly all the boxes for my review except two that I was not sure about.
Regarding 2), I saw that you have guidelines for third party wishing to report issues on the repo landing page, but not for the other two cases.
Hi @elenlefoll, thank you for your feedback!
The code includes automated tests, they are in tests
.
My colleagues will probably have a better insight regarding the community guidelines.
Hi!
I am reviewing your JOSS paper on this package (https://github.com/openjournals/joss-reviews/issues/7024) and I am encountering an error on installation:
I am running:
> session_info() ─ Session info ─────────────────────────────── setting value version R version 4.4.1 (2024-06-14) os macOS Sonoma 14.5 system aarch64, darwin20 ui RStudio language (EN) collate en_US.UTF-8 ctype en_US.UTF-8 tz Europe/Madrid date 2024-07-24 rstudio 2024.04.2+764 Chocolate Cosmos (desktop) pandoc NA
Any ideas what is going wrong?