search

annagraff / densify

GNU Affero General Public License v3.0
0 stars 0 forks source link

Update DESCRIPTION #8

Closed HedvigS closed 1 month ago

HedvigS commented 1 month ago

Would it be okay to add bookdown to the description?

annagraff commented 1 month ago

absolutely

tzakharko commented 1 month ago

This kind of dependency should be added in Suggests rather than Imports as per Writing R Extensions manual.

HedvigS commented 1 month ago

This kind of dependency should be added in Suggests rather than Imports as per Writing R Extensions manual.

Okay, up to you. I just wanted to prevent the issue experienced in #7

annagraff commented 1 month ago

Changed from Imports to Suggests with the last commit.

tzakharko commented 1 month ago

This kind of dependency should be added in Suggests rather than Imports as per Writing R Extensions manual.

Okay, up to you. I just wanted to prevent the issue experienced in #7

Oh, it should absolutely be listed since building vignettes requires it. It's just not relevant to the core package functionality, hence it should go into suggests like other similar dependencies do. The R team explicitly asks for such packages to be added as suggested to prevent dependency explosions and allow lean installations.

Thanks for taking care of this!