search

annajiat / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

minidump_stackwalk: Show argument registers for ARM stack traces #504

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
For issue chromium-os:36182, posciak@ asked if the argument registers (r0-r3) 
could also be shown in an ARM stack trace.

For the most part, they won't be valid because they're not permanent regs (i.e. 
not callee saves).  However, they _may_ actually be valid for the bottom-most 
frame (i.e. the crashing function).

Original issue reported on code.google.com by mkr...@chromium.org on 14 Nov 2012 at 3:06

GoogleCodeExporter commented 9 years ago 
It looks like all the code is basically written to handle this if there are 
STACK CFI records, so by just adding printing code I was able to get what looks 
to be valid register values (posciak@ will confirm they're valid in issue 
chromium-os:36182).

Original comment by mkr...@chromium.org on 14 Nov 2012 at 3:07

GoogleCodeExporter commented 9 years ago 
There's a CL at https://breakpad.appspot.com/497002/.

Original comment by mkr...@chromium.org on 14 Nov 2012 at 3:25

GoogleCodeExporter commented 9 years ago

Original comment by mkr...@chromium.org on 14 Nov 2012 at 8:19

GoogleCodeExporter commented 9 years ago 
Fixed in r1108.

Original comment by ted.mielczarek on 17 Apr 2013 at 1:44

GoogleCodeExporter commented 9 years ago 
Thanks for landing that CL for me.

Original comment by mkr...@chromium.org on 17 Apr 2013 at 10:48