annando / salmon-protocol

Automatically exported from code.google.com/p/salmon-protocol
0 stars 0 forks source link

MagicSig encoding discrepency #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In
http://salmon-protocol.googlecode.com/svn/trunk/draft-panzer-magicsig-00.html
, <me:encoding> is listed as a separate element, but the example in 4.
shows "encoding" as an attribute on <me:envelope> .

I noticed the playground code also looks for encoding as an attribute...
which is "correct" ?

Original issue reported on code.google.com by wal...@gmail.com on 26 Feb 2010 at 5:43

GoogleCodeExporter commented 9 years ago
Encoding should be a separate element.  I missed updating the playground code 
(and 
thus, um, the examples I generated using it).  Will fix!

Reason:  Encoding applies to two other elements, the signature and the content, 
and 
there is absolutely no reason anyone would ever use two different encodings.  
In fact the 
encoding is fixed to one value for this version of the spec.

Original comment by jpanzer@google.com on 26 Feb 2010 at 6:01

GoogleCodeExporter commented 9 years ago
Awesome! That's what I had figured (that it should be a separate element, 
because it applies to other elements) 
and was how I wrote our code :-)

Original comment by wal...@gmail.com on 26 Feb 2010 at 6:03

GoogleCodeExporter commented 9 years ago
Fixed.

Original comment by jpanzer@google.com on 1 Mar 2010 at 11:51

GoogleCodeExporter commented 9 years ago
Fixed in r40.

Original comment by jpanzer@google.com on 1 Mar 2010 at 11:54