search

annayqho / TheCannon

a data-driven method for determining stellar parameters and abundances from stellar spectra
MIT License
39 stars 16 forks source link

Issue at the Training Step #71

Open jsobeck opened 7 years ago

jsobeck commented 7 years ago

Hi Anna,

I encountered an issue in the training step of this particular github distribution of The Cannon. It occurs (e.g.) in line 188 of train_model.py with the error "AttributeError: 'NoneType' object has no attribute 'T'". I installed The Cannon with pip and did not experience this issue. I will try to troubleshoot.

Best, JS

hypergravity commented 7 years ago

The reason should be the addition of the optional parameter wl_filter. Older versions without this parameter do not have this problem. Check this commit https://github.com/annayqho/TheCannon/commit/dad45dcf60717f7fce402d07887ef3090beeb123

jsobeck commented 7 years ago

Thanks for this. Anna mentioned that she tried to implement wavelength filters, but was not completely successful. Also as noted above, the pip install (and older) version does not produce this error.