search

annayqho / TheCannon

a data-driven method for determining stellar parameters and abundances from stellar spectra
MIT License
39 stars 16 forks source link

dataset input parameters? #72

Open annayqho opened 7 years ago

annayqho commented 7 years ago

@aceilers -- I was wondering wha the "coeff_old" and "scatter_old" parameters are in the Dataset code. They cause my existing code to break :). Are they temporary or should we find a way to incorporate them? Perhaps we could make them optional parameters (like _coeff_old and _scatter_old)?

aceilers commented 7 years ago

Hi Anna,

I changed things again this week, because we found a bug… Basically coeff_old are the coefficients from using the old Cannon version, i.e. the original one. They are input parameters as an initial guess for the optimizer for the new version. Give me another week or so and it hopefully works ;)

Best, Christina

Am 24.03.2017 um 19:47 schrieb Anna Ho notifications@github.com:

@aceilers https://github.com/aceilers -- I was wondering wha the "coeff_old" and "scatter_old" parameters are in the Dataset code. They cause my existing code to break :). Are they temporary or should we find a way to incorporate them? Perhaps we could make them optional parameters (like _coeff_old and _scatter_old)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/annayqho/TheCannon/issues/72, or mute the thread https://github.com/notifications/unsubscribe-auth/AT1lwBR4kB0aAgUUnW-Y1S96yT4FOupaks5rpA_OgaJpZM4Moo0z.

annayqho commented 7 years ago

Oh OK, great. Just wanted to check, thanks!