annegerben / oversight

Automatically exported from code.google.com/p/oversight
0 stars 1 forks source link

Certificate scraping is case sensitive #345

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
First of all, I think the description on cert_country_list is not acurate. 
I thing that it would have been better if it states that it only excepts 
country abbreviations.

The Ireland example sets a wrong example since it is hard coded on line 
510.
You might also might rethink line 508,509 since USA is not the correct 
abbreviation... and currently never gets matched by IMDB anyway since it 
is uppercase. (all certificates country abbreviations results from imdb 
are lowercase)
UK is however a correct abbreviation, but it never matched it since it is 
uppercase also.

I changed line 510 to
split(tolower(g_settings
["catalog_cert_country_list"],gCertificateCountries,",");

To make it all lowercase so it would match when comparing 
if (cert[1] == gCertificateCountries[c]) { 
on line 6584

I tested it with NL in the settings and now it works perfectly.... (after 
removing my imdb cache files in the oversight directory)

Original issue reported on code.google.com by nico%ber...@gtempaccount.com on 5 May 2010 at 1:22

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
I would love an editing button on google code, so I could have corrected my 
typo/
spelling errors :)

also missed an ) before the , in the code

And I have created the attached pngs based on the official dutch certification 
organisation, Kijkwijzer (http://www.kijkwijzer.nl/pagina.php?id=15)

Original comment by nico%ber...@gtempaccount.com on 5 May 2010 at 4:57

Attachments:

GoogleCodeExporter commented 8 years ago
Found the vectors of the logos... so I made new PNGs...

Original comment by nico%ber...@gtempaccount.com on 5 May 2010 at 6:34

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks , I'll look at this for sure ! 

Sorry been tied up with the gui skin changes lately.

Original comment by lordylo...@gmail.com on 30 Jul 2010 at 2:59