annegerben / oversight

Automatically exported from code.google.com/p/oversight
0 stars 1 forks source link

[SKINNING] Grid Configuration #385

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Allow the skin to configure the grid size shape layout and position to allow 
images to be set to the 
side of the grid etc.

Original issue reported on code.google.com by keith.ja...@gmail.com on 30 May 2010 at 12:14

GoogleCodeExporter commented 8 years ago
The GRID macro can take parmeters (rows, cols ) that overides the ones in the 
main
config file.

The position of the grid should be determined by the surrounding HTML in the 
skin.

I'll just double check the grid is always 100% wide and you can put its 
containing
element wherever you want in the skin itself ?

So in the skin you can use syntax like [:GRID(4,5):] instead of just [:GRID:]

This goes for the boxset view also.
It's always been there - just badly documented. I've started a proper skinning
document on the wiki and will fill out as I go along...

I probably need to add poster dimension arguments too..

Original comment by lordylo...@gmail.com on 30 May 2010 at 1:29

GoogleCodeExporter commented 8 years ago
Ideally (Moon on a Stick) I'd like to have different max lengths for each row 
so the top row could be, say 8 wide 
and the bottom row 6

Original comment by keith.ja...@gmail.com on 30 May 2010 at 10:06

GoogleCodeExporter commented 8 years ago
I believe that the grid always takes up the entire width of the screen as well. 
In order for this to be usable at a 
skin level we would need to be able to configure...

Grid max height and max width (like a box that it sits in?)
Rows and columns override (available already)
Poster size override

From what I can remember, the grid width is determined largely by it's content 
- You can only use this 
usefully to constrain within a skin design if you can specify overrides for 
both rows and columns and the 
poster size, else you have an uncontrolled variable that throws the design out 
entirely.

Original comment by keith.ja...@gmail.com on 30 May 2010 at 11:31

GoogleCodeExporter commented 8 years ago
OK so as long as grid sits within a <table width=100%> then I think the skin 
maker
can use the containing element to position it., and the rows,cols,and image
dimensions to size it. 

And it seems like the best solution is to have 
[:GRID(offset,r,c,imgh,imgw,last):] 

Then you can have multiple grids per page, scattered around.

 The one with offset=0 will have the navigation controls to the previous page...

 The one with 'last' set will have the navigation controls to the next page...

For now we can leave navigation between grid_rows up to gaya. If that doesn't 
work
out, then we'll code that in later?

PS I did think oversight should know which one is last due to the highest 
offset, but
this would mean making two passes of the template code.

Original comment by lordylo...@gmail.com on 30 May 2010 at 1:54

GoogleCodeExporter commented 8 years ago
Sweet!

This is just what the blu design has been waiting for!

Original comment by keith.ja...@gmail.com on 30 May 2010 at 3:52

GoogleCodeExporter commented 8 years ago
Issue 230 is fixed , and the grid segments , once coded, will be able to 
override the configured grid order.

Original comment by lordylo...@gmail.com on 17 Jun 2010 at 12:04

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Test updates by reconfiguring skins - Assign back to lordy when completed

Original comment by keith.ja...@gmail.com on 10 Sep 2010 at 8:32

GoogleCodeExporter commented 8 years ago
PS there is no need for the 'last' parameter anymore.

Original comment by lordylo...@gmail.com on 10 Sep 2010 at 9:06

GoogleCodeExporter commented 8 years ago
This has improved, but still isn't quite working. A single grid works fine. 
However, the following sample layout...

                    [:GRID(rows=>1,cols=>6,offset=>0):]
                    [:GRID(rows=>1,cols=>3,offset=>6):]

Shows just a blank screen - What I want here is a layout like this (assume the 
stars are posters...)

* * * * * *
* * *

Original comment by keith.ja...@gmail.com on 11 Sep 2010 at 12:34

GoogleCodeExporter commented 8 years ago
Hi, I have tested split segment working,
I need to see your input template and your output html log

PS you dont need to specify offset anymore if the grids appear in the normal 
order within the HTML stream.

I think you only need offset now if for example you had for grids in a table 
with the following order. ...

G1 G3
G2 G4

But for most simple cases the natural HTML order will work..

Original comment by lordylo...@gmail.com on 11 Sep 2010 at 3:19

GoogleCodeExporter commented 8 years ago
PS Sometimes it is often a typo because the syntax I used is a little painful!

I'll overhaul it one day in the future..

Original comment by lordylo...@gmail.com on 11 Sep 2010 at 3:21

GoogleCodeExporter commented 8 years ago
PPS here is a working one in the repository , but I removed it because users 
wanted to be able to resize the grid via the main screen.

Otherwise The stuff in RED was working well

http://code.google.com/p/oversight/source/diff?spec=svn1441&r=1418&format=side&p
ath=/trunk/templates.new/classic/any/menu.template&old_path=/trunk/templates.new
/classic/any/menu.template&old=1389

Original comment by lordylo...@gmail.com on 11 Sep 2010 at 3:24

GoogleCodeExporter commented 8 years ago
That's the problem right there! It seems to work fine until you drop the offset 
parameter into the equation, then it dies - This is fine.

Thanks!

Original comment by keith.ja...@gmail.com on 11 Sep 2010 at 4:54