Closed mndrix closed 2 years ago
Thank you very much for putting in the time to get this working on OpenBSD!
I've had a few minor comments in the commit, mostly about finagling the comments a bit.
I've had a few minor comments in the commit, mostly about finagling the comments a bit.
For some reason I don't see your comments on the commit. If you can let me know how you'd like me to fix the comments, I'll gladly update the pull request.
I've had a few minor comments in the commit, mostly about finagling the comments a bit.
For some reason I don't see your comments on the commit. If you can let me know how you'd like me to fix the comments, I'll gladly update the pull request.
My bad! I forgot to close the review.
mndrix:openbsd #9
Thanks for suggestions. I now see what you mean about the comments mirroring the Ada API. I've pushed a commit to restore the original comment and describe the new C names. Let me know if you want further touchups.
Looks great. Thank you for your contributions, and bringing AURA to OpenBSD!
On OpenBSD (and maybe elsewhere?), stdio.h has the following macros:
which causes the following compilation errors on child_processes-platform-binding.c:
This commit renames {stdin,stdout,stderr} to {stdinput,stdoutput,stderror} to avoid colliding with the macros. The names I chose aren't great, but they work and I don't have a better idea.