search

annk15 / MTGKeywordHelper

A tool to search and find descriptions for keywords used in magic the gathering
MIT License
2 stars 0 forks source link

Minify CSS, HTML and JS before merging with Main branch #11

Open oscar-larm opened 3 months ago

oscar-larm commented 3 months ago

Remember to minify the frontend parts into a optimized branch before merging into the main branch for slight performance gain!

annk15 commented 3 months ago

I think we should focus on keeping the readability in the main branch also as we may need to clone from this when fixing bugs in the future but we could minify the the frontend code before we create a release.

oscar-larm commented 3 months ago

I think we should focus on keeping the readability in the main branch also as we may need to clone from this when fixing bugs in the future but we could minify the the frontend code before we create a release.

Yeah waiting until the release build to minify is definetly smarter. Something we could do is automate minify to happen automatically when the working css file is saved, and save the minify version in a seperate release-directory. We could do this with Node.js and Gulp.

annk15 commented 3 months ago

I think we should focus on keeping the readability in the main branch also as we may need to clone from this when fixing bugs in the future but we could minify the the frontend code before we create a release.

Yeah waiting until the release build to minify is definetly smarter. Something we could do is automate minify to happen automatically when the working css file is saved, and save the minify version in a seperate release-directory. We could do this with Node.js and Gulp.

Yes that sounds good, if it slow down the ide too much we could create do the optimisation automatically when the dev branch is pushed in to master. We will later tag the master branch with release tags when we feel happy with the state.