annolinux / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
0 stars 0 forks source link

http and mmshttp streams #223

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In file support.c in function 'add_item_to_playlist' at line 1624:
...
if (g_str_has_prefix(uri, "http://")) {
    unescaped = switch_protocol(uri, "mmshttp");
    g_free(local_uri);
    local_uri = g_strdup(unescaped);
    g_free(unescaped);
}
...

I believe it's wrong behavior, because there are a lot of 'http' streams 
too, and this replacement makes them unplayable (when 'http' stream 
passing as argument to a new instance og gnome-mplayer all is ok, but when 
it's passing to already running instance through dbus or gui this part of 
code replaces 'http' with 'mmshttp' and stream can't be played).

Original issue reported on code.google.com by assaul...@googlemail.com on 3 Jul 2009 at 3:45

GoogleCodeExporter commented 9 years ago
Works with all sites I tried as it first tries with mmshttp and if that doesn't 
work
it falls back to http...

If you have one that fails, please point it out.

Original comment by kdeko...@gmail.com on 3 Jul 2009 at 3:58

GoogleCodeExporter commented 9 years ago
http://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel - for example
When it's opening first time all is ok, but it fails to play second time in 
same 
instance.

Log for first time (all is ok - fallback is working):
$ gnome-mplayer http://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel
GNOME·MPlayer·v0.9.7
[skipped]
adding http://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel to playlist (cancel = 0)
playing - mmshttp://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel
[skipped]
Playing mmshttp://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel.
ERROR: mplayer: could not connect to socket
STREAM_ASF, URL: mmshttp://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel
ERROR: mplayer: No such file or directory
[skipped]
playing - http://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel

For second time in same instance:
[skipped]
playing - mmshttp://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel
[skipped]
Playing mmshttp://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel.
ERROR: mplayer: could not connect to socket
STREAM_ASF, URL: mmshttp://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel
ERROR: mplayer: No such file or directory
[skipped]
Resolving radio.mv.ru for AF_INET...
Connecting to server radio.mv.ru[89.239.131.142]: 80...
ERROR: unknown ASF streaming type
ERROR: Failed, exiting.
Thread completing
shutting down threadquery for mmshttp://radio.mv.ru:80/16bit.FM_I.D.E.A.Channel 
since threaddata->done is TRUE

Without that replacement of 'http' with 'mmshttp' all is working fine.

Original comment by assaul...@googlemail.com on 3 Jul 2009 at 4:45

GoogleCodeExporter commented 9 years ago
I am unable to duplicate your issue...

Using stop or double clicking on the stream in the playlist restarts the media 
fine.
How are you getting the second instance to work. Also are you canceling it 
while it
is caching?

Original comment by kdeko...@gmail.com on 3 Jul 2009 at 1:18

GoogleCodeExporter commented 9 years ago
It happens when i try to add a new or the same http stream through dbus or 
'open 
location' dialog. For simplicity i attached a screencast.

Original comment by assaul...@googlemail.com on 3 Jul 2009 at 1:33

Attachments:

GoogleCodeExporter commented 9 years ago
Should work correctly now...

mmshttp urls are important for some sites, so I could not just disable them. 
Also
mmshttp:// urls fail a little more reliably than http urls so easier to got 
mmshttp
-> http than http->mmshttp

Original comment by kdeko...@gmail.com on 3 Jul 2009 at 2:25

GoogleCodeExporter commented 9 years ago
It's almost ok now, except that there is need to start playback manually after 
opening new stream. Log looks like that just after loading new stream it's 
still 
trying only mmshttp, but after pressing 'play' button it works correctly and 
trying 
both protocols.

Original comment by assaul...@googlemail.com on 3 Jul 2009 at 2:40

GoogleCodeExporter commented 9 years ago
I don't see that in my testing

Original comment by kdeko...@gmail.com on 3 Jul 2009 at 5:15

GoogleCodeExporter commented 9 years ago
I see it when using the dbus method, but not with open location... appears to be
another issue that I will have to debug. For some reason the new item is 
invalid.

Original comment by kdeko...@gmail.com on 3 Jul 2009 at 5:26

GoogleCodeExporter commented 9 years ago
Ok, problem is worked around now.

Original comment by kdeko...@gmail.com on 3 Jul 2009 at 5:40