search

annotorious / annotorious-openseadragon

An OpenSeadragon plugin for annotating high-res zoomable images
https://annotorious.github.io
BSD 3-Clause "New" or "Revised" License
124 stars 42 forks source link

Newest release has error. See attached image. #128

Closed dnoneill closed 2 years ago

dnoneill commented 2 years ago

When trying to load the newest release the following error occurs.

Screen Shot 2022-06-15 at 3 07 21 PM
rsimon commented 2 years ago

Ok, weird. Doesn't seem to happen in the default setup. Can you say a bit about yours? Are you using script tag imports or npm? If script: in what order are you importing? Are using it with OSD v3.x?

darwinjob commented 2 years ago

I confirm this. First of all, if you click on the release link you will see something weird: image

This is broken:

<script src="https://cdnjs.cloudflare.com/ajax/libs/openseadragon/3.1.0/openseadragon.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@recogito/annotorious-openseadragon@2.7.5/dist/openseadragon-annotorious.min.js"></script>

However, this works:

<script src="https://cdnjs.cloudflare.com/ajax/libs/openseadragon/3.1.0/openseadragon.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@recogito/annotorious-openseadragon@2.7.6/dist/openseadragon-annotorious.min.js"></script>
dnoneill commented 2 years ago

@rsimon The library I used was the release in the screenshot that I downloaded and loaded. I use script tags and use the order that I used before which is openseadragon, annotorious, openseadragon-annotorious

rsimon commented 2 years ago

Yikes - sorry for this. Now I remember... ;-) Yes, I managed to build & release v2.7.5 with a broken build config. I did fix the bug, and pushed v2.7.6 to the npm registry (and the CDN). But then forgot to publish a ZIP package on GitHub. (Lesson learned: never do this stuff late at night...)

So as an immediate fix: you can pull the latest version - which is actuall v2.7.6 now - from the CDN here:

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@recogito/annotorious-openseadragon@2.7.6/dist/annotorious.min.css">

<!-- JS -->
<script src="https://cdn.jsdelivr.net/npm/@recogito/annotorious-openseadragon@2.7.6/dist/openseadragon-annotorious.min.js"></script>

I'll roll a GitHub release for v2.7.6, too, unpublish the broken v2.7.5, and close the issue when that's done.

Cheers, thanks for reporting & sorry for the inconvenience!