search

annotorious / annotorious-openseadragon

An OpenSeadragon plugin for annotating high-res zoomable images
https://annotorious.github.io
BSD 3-Clause "New" or "Revised" License
124 stars 42 forks source link

"Annotation deselect when selecting programmatically" fix in this plugin? #137

Closed Neirokin closed 2 years ago

Neirokin commented 2 years ago

I have the same problem (https://github.com/recogito/annotorious/issues/207) with this plugin. Have you added a fix here?

rsimon commented 2 years ago

Ok, weird. Although the consequence is the same, this issue is completely different internally. It looks like OpenSeadragon just stops firing events after programmatic selection (it's not even possible to navigate the image). I'll investigate.

thanhhau097 commented 2 years ago

I still face this problem with the newest version on the main branch. After we call anno.selectAnnotation(annotationId), we can only interact with OSD when we hover the mouse over/click on the annotation. Can you please have a look again?

rsimon commented 2 years ago

Yikes - looks like I had my testing set up incorrectly the last time. I think this should work now (after the commit above). But will need to check back more thoroughly later. I'm re-opening the issue.

thanhhau097 commented 2 years ago

Thanks so much for a very quick fix. I tested it with my case and now it works well.