annotorious / annotorious-openseadragon

An OpenSeadragon plugin for annotating high-res zoomable images
https://annotorious.github.io
BSD 3-Clause "New" or "Revised" License
121 stars 43 forks source link

Annotation isn't draggable if drawing enabled #167

Open alexeykurbako opened 1 year ago

alexeykurbako commented 1 year ago

Hi, After migration to OSD version 4.0.0 and Annotoriuos v.2.7.10 existing annotations became undraggable if drawing mode enabled, but everything is fine it's disabled. I tried to debug it a bit and found out that it doesn't raise clickAnnotation event in draw mode. The second problem happens if I try to click in just random place and draw annotation after it so it doesn't draw anything, but after disabling and enabling draw mode everything is fine. I think both issues are related but don't understand why they happen and how to solve them.

anno-issue

OSD version: 4.0.0 Annotoriuos version: 2.7.10 React version: 17.0.2 OS: Ubuntu 20.04.4 Browser: Google Chrome Version 102.0.5005.61 (Official Build) (64-bit)

rsimon commented 1 year ago

Yikes, thanks for reporting. There seem to be a couple of changes in OSD 4.0 that broke Annotorious/OSD interop. I've been working out some of them, but it might still take a while until I can iron them all out. I'll put that one on the list!

alexeykurbako commented 1 year ago

@rsimon Thank you for quick response. I will wait for you to fix this problem, but for now will stay on the older version of OSD and Annotoriuos

alexeykurbako commented 9 months ago

@rsimon Hey. Do you have any progress with this issue?

alexeykurbako commented 8 months ago

@rsimon

rsimon commented 8 months ago

Hi, sorry - this completely dropped off my radar. I can see the problem. But I'm afraid this isn't going to be fixed in Annotorious v2.x any more. Event handling has become so convoluted, with so many edge cases, that one of the recent changes seems to have made this pretty much impossible. Selection is completely disabled while drawing is active.

Annotorious v.3 is almost ready to go - a complete rewrite from scratch, exactly because of legacy problems like this. So a solution is one the horizon, I guess. Sorry for not having better news at this point.