search

annotorious / annotorious-openseadragon

An OpenSeadragon plugin for annotating high-res zoomable images
https://annotorious.github.io
BSD 3-Clause "New" or "Revised" License
121 stars 43 forks source link

OpenSeaDragon@^5.0.0 is unsupported by annotorious-openseadragon #171

Open zfox23 opened 1 year ago

zfox23 commented 1 year ago

Hello! Thanks for maintaining this plugin.

When doing: npm install @recogito/annotorious-openseadragon

I get:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: zach-fox-photography@1.0.0
npm ERR! Found: openseadragon@4.1.0
npm ERR! node_modules/openseadragon
npm ERR!   openseadragon@"^4.1.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer openseadragon@"^3.0.0" from @recogito/annotorious-openseadragon@2.7.10
npm ERR! node_modules/@recogito/annotorious-openseadragon
npm ERR!   @recogito/annotorious-openseadragon@"*" from the root project

I'm going to try to --force install the plugin and see what happens - but it'd be great to have OSD v5+ support. 🙂

rsimon commented 1 year ago

There was an issue with OSD 4.0 and keeping annotations in sync while pinch-rotating. But that should be fixed now in OSD 4.1 (which is the latest). Let me know how it goes, and I'll update the peer dependency in package.json.

pmandalka commented 7 months ago

The Test-Page was already migrated to 4.1 in https://github.com/annotorious/annotorious-openseadragon/commit/0a4f32c33babc5ae73be137a25cb93c5446e6feb - maybe the peer dependency should be updated.