search

annotorious / annotorious-openseadragon

An OpenSeadragon plugin for annotating high-res zoomable images
https://annotorious.github.io
BSD 3-Clause "New" or "Revised" License
121 stars 43 forks source link

Pass image to parseRectFragment for percent format #180

Closed blms closed 1 year ago

blms commented 1 year ago

Hi @rsimon, just wanted to pass along this fix for a bug that was preventing us (in the Princeton Geniza Project) from upgrading Annotorious-OSD above v2.7.6.

parseRectFragment was never receiving the image as a second argument, so fragment selectors using the percent format would fail on image.naturalWidth (as image was undefined).

rsimon commented 1 year ago

Thanks!! (Interesting this remained unnoticed for so long...)

geoffroy-noel-ddh commented 1 year ago

Ah, thanks! I actually noticed that bug months ago but only got a chance to looked into it today and discovered by coincidence @blms had just fixed it.

dpdabb1e commented 12 months ago

Same here, I just discovered this PR because I found the bug locally. What version is this in?

rsimon commented 12 months ago

Looks like this fix arrived just a few days after I had published the latest release (v2.7.11). I published a new one just now - v.2.7.12. This has the PR included.

dpdabb1e commented 12 months ago

Thank you so much for releasing this! My workaround was pretty complex, now I just have to change one line.

rsimon commented 12 months ago

Excellent - and don't forget there's a Patreon or Steady to support my work if you want, he he 😉