annotorious / annotorious-openseadragon

An OpenSeadragon plugin for annotating high-res zoomable images
https://annotorious.github.io
BSD 3-Clause "New" or "Revised" License
121 stars 43 forks source link

Drawing tools stuck after single click #186

Closed sinamcr7 closed 7 months ago

sinamcr7 commented 10 months ago

Hi I'm using annotorious-openseadragon and annotorious-selector-pack to annotate my WSI images but when using any tool other than the point tool if I single click and don't drag and drop while holding shift that tool gets stuck and just pans, so it won't work until I refresh page or use point tool and go back to desired drawing tool, its a temporary fix and the bug is so annoying, please if someone has any fixes for this help me. here's how it happens: bug gif

rsimon commented 10 months ago

Look like the last commit (https://github.com/annotorious/annotorious-openseadragon/commit/ffc98263c8cdc4c091583e09ae1eb304841d42c7) has fixed this. I published a new release (2.7.14).

sinamcr7 commented 10 months ago

thanks alot

blms commented 7 months ago

I think I'm still experiencing a version of this with the polygon tool. It can be observed on the example page here:

Something similar happens when you press Escape while in the middle of drawing a polygon. I suspect both have something to do with the polygon's stop() function, so maybe it warrants a new issue?

EDIT: Actually, it looks like the original issue is still happening with the rectangle tool as well—shift+click without dragging, only pan is possible until releasing shift.

blms commented 7 months ago

Notes from working on this a bit more: