search

annotorious / annotorious-v1

Project has moved to http://github.com/annotorious/annotorious
https://annotorious.com
MIT License
593 stars 142 forks source link

Mobile support for OpenLayers #140

Open moschlar opened 8 years ago

moschlar commented 8 years ago

I just noticed that Annotorious does not show the annotation when tapping on it for an OpenLayers map, but it does for a plain image. I suppose its due to the fact that annotorious.mediatypes.openlayers.Viewer.prototype.getAnnotationsAt et al are not yet implemented - or are there other problems regarding touch and OpenLayers? If not, I would try to implement that quickly.

rsimon commented 8 years ago

To be honest, I didn't look into mobile-compatibility with OpenLayers at all. There's definitely hidden potential for Yak-shaving for anyone looking into it, I'd say. Implementing getAnnotationsAt is probably the key to making existing annotations 'clickable'. But enabling touch-based creation of annotations would be another matter.

I think there is one (or two?) forks out there where people have looked into touch-support more generally. One day I hope I can take some time to re-consolidate these bits into the main codebase. But at the moment I don't have the time to give Annotorious the attention it deserves :-(

moschlar commented 8 years ago

Ok, so I started shaving: I "implemented" (a.k.a. copy-pasted and slighty adapted the code from image.viewer.js) getAnnotationsAt for openlayers.Viewer. Sadly, this doesn't seem to be sufficient already.

From glancing at the other initialization/listener code, it seems that there are quite some differences in the event handler attachment code between the two viewers...

I'll be experimenting further in my branch https://github.com/moschlar/annotorious/tree/openlayers-touch, if you have any hints or ideas, I'd be more than happy about it. I'm neither good at Closure, nor at JavaScript in general...