search

annotorious / annotorious-v1

Project has moved to http://github.com/annotorious/annotorious
https://annotorious.com
MIT License
593 stars 142 forks source link

Trouble building with "mode":"ADVANCED" - resource /contrib/json.js relative to ResourceReader not found #149

Open notbrain opened 8 years ago

notbrain commented 8 years ago

Just downloaded the latest plovr.jar from https://github.com/bolinfest/plovr and was able to build annotorious in RAW mode, but ADVANCED mode threw this:

$ java -jar plovr4.jar build ../standalone.json > annotorious.min.js
Exception in thread "main" java.lang.IllegalArgumentException: resource /contrib/json.js relative to org.plovr.ResourceReader not found.
  at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
  at com.google.common.io.Resources.getResource(Resources.java:209)
  at org.plovr.ResourceJsInput.getCodeWithEtag(ResourceJsInput.java:38)
  at org.plovr.ResourceJsInput.generateCode(ResourceJsInput.java:56)
  at org.plovr.AbstractJsInput.cacheExpensiveValuesIfNecessary(AbstractJsInput.java:126)
  at org.plovr.AbstractJsInput.getCode(AbstractJsInput.java:51)
...

Looks like json.js and webkit_console.json should be commented out (or removed) instead of prefixed with double slashes? Are these safe to omit?

diff --git a/standalone.json b/standalone.json
index a777d38..6a4632d 100644
--- a/standalone.json
+++ b/standalone.json
@@ -17,11 +17,11 @@
     "externs/openlayers.externs.js",
     "externs/openseadragon.externs.js",
     "externs/jquery.externs.js",
-    "//json.js",
-    "//webkit_console.js"
+    //"json.js",
+    //"webkit_console.js"
   ],

Also tried the built-in plovr.jar and another archived on GC, but the above bolinfest version was the only one that worked at all. I'm on OSX Yosemite iMac 5k.