search

annotorious / annotorious-v1

Project has moved to http://github.com/annotorious/annotorious
https://annotorious.com
MIT License
592 stars 142 forks source link

Doesn't Work on Leap Motion in Chrome/FF #67

Open thestonefox opened 11 years ago

thestonefox commented 11 years ago

I may be missing something obvious, but trying:

http://annotorious.github.io/demos/hello-world.html

in either chrome Version 28.0.1500.95 m or Firefox v23

I cannot draw annotations on the images. They appear on the image and it says "click and drag to annotate"

It also doesn't display any javascript errors.

Just doesnt work.

Works fine still in IE9 (how funny that IE is the one not causing issues!)

This worked just a few days ago (as I was testing it fine in chrome and firefox)

thestonefox commented 11 years ago

Well this is an odd one for you :)

I have recently installed a leap motion and my guess is this:

It installs Windows 7 multi touch drivers on the machine (so the leap can pretend to be multi touch).

I'm guessing this adds a veneer of a touch layer to certain apps (e.g. firefox, chrome)

so there is no click event registered, so you cannot draw annotations even with the mouse.

I'm guessing it works in IE because microsoft compensate for the touch screen driver.

When I uninstall the leap (and it also uninstalls the touch screen drivers) then the demo link works fine in chrome, but with it installed, it doesn't work.

So..... I don't know if you want to consider this a bug or not :)

rsimon commented 11 years ago

Indeed - that's an odd one. Your Leap Motion guess sounds reasonable. I wonder if it's turning your machine into a "full blown" touch device (as it were), or whether it enables a mix of mouse/touch events (which would be problematic...)

The timing is also a funny coincidence: because I worked on Annotorious touch support yesterday and just now made it go live on the demo Web page! So you could give it another try if you want. (I'm still testing it myself, so it may be a bit buggy. But once it's stable, it's going to be the main new feature of v0.6.)

<Works fine still in IE9 (how funny that IE is the one not causing issues!)>

Ah that's great. Then I could maybe just add a banner to the demo page saying "Best Viewed with Internet Explorer" (preferably in some blnking font :-D)

thestonefox commented 11 years ago

New one seems worse in chrome/firefox with the leap installed. Doesn't even show the comments on hover now.

Still works fine in ie though :)

Go for Comic Sans pink marquee text saying "Best Viewed with Internet Explorer" just to be on the safe side...

I'll check netscape navigator compatibility too :p

rsimon commented 11 years ago

The mouse hover comments are disabled in touch mode (feature, not bug ;-), since normally there wouldn't be any mouseover events, anyway. But I'll re-enable them. They'll be useless on tablets, but they also won't hurt or interfere with anything. Can you draw the annotations?

Comic Sans! Yes - I should have thought of that :-D

thestonefox commented 11 years ago

Perhaps onTouch the annotations could appear? But then i guess on touch you should just see the edit box anyway :)

which is probably what happens and it just doesn't work for me in chrome + leap!

So....no I still couldn't draw annotations in chrome on the latest version.

Don't worry though, I don't think that many people will buy a leap!

rsimon commented 11 years ago

Hm - in fact they weren't explicitely disabled. But there was one small issue I fixed. So this may help them to re-appear. But frankly I don't know what exactly is going on. The Leap doesn't seem to turn the browser into a "real" touch device. But rather something that supports a mix of mouse/touch events. I guess without access to a Leap, I must admit defeat on this one.

Too bad - image annotation with the leap motion would have been cool... I'll rename the issue. But keep it open. One never knows ;-)

rsimon commented 11 years ago

PS: on touch the Annotations should appear, if the device is a touch device. I'll make an addition that the annotations also appear on click. This should cover that behavior in any case.

thestonefox commented 11 years ago

I wonder if someone who has a touch screen windows 7 machine (e.g. one of those all in one PCs) would have the same problem with touch.

I have a windows 8 laptop somewhere, I'll dig it out and try with the leap on that, because I think windows 8 has touch built in from ground up and my guess is its not actually the leap thats the problem but the windows 7 touch interface (or at least the drivers).

I'll keep you posted.

rsimon commented 11 years ago

Great! Thx - PS: I just made another update. Now, if there is any sort of touch, click, whatever event on an annotation, it's supposed to highlight.