search

annotorious / annotorious-v2-selector-pack

Additional selection tools for Annotorious and the Annotorious OpenSeadragon plugin
BSD 3-Clause "New" or "Revised" License
14 stars 19 forks source link

Register the RubberBandCircleTool in the ToolsRegistry #1

Closed Hero-Solutions closed 3 years ago

Hero-Solutions commented 3 years ago

Registering the RubberBandCircleTool in the ToolsRegistry currently still happens in the main repository. This probably needs to moved to the selector pack. I'd do it myself, but I'm not sure what the preferred way is to do this.

rsimon commented 3 years ago

Thanks - missed that. Yes, the registration can be removed from the ToolsRegistry class. The SelectorPack plugin registers the circle implementation in index.js (when it calls .addDrawingTool).

Hero-Solutions commented 3 years ago

Oh, good. I hadn't noticed that calling .addDrawingTool also registers the drawing tool with the ToolsRegistry.

Hero-Solutions commented 3 years ago

Fixed in https://github.com/recogito/annotorious/pull/135.

Hero-Solutions commented 3 years ago

This issue can be closed as the circle drawing tool has been moved from the core distribution into the selector pack plugin.