search

annotorious / annotorious-v2-selector-pack

Additional selection tools for Annotorious and the Annotorious OpenSeadragon plugin
BSD 3-Clause "New" or "Revised" License
14 stars 20 forks source link

Added multipolygon-annotation #13

Closed erikradisch closed 2 years ago

erikradisch commented 3 years ago

This is an extension for multiplygon-support. should work smoothly. However, I had to modify support-function of freehand as they have both nearly the same svg-setting.

rsimon commented 2 years ago

Sorry it took my way too long to review this (completely dropped off my radar - thank god for the holiday break ;-) Thanks, Erik, I'm merging this now!

rsimon commented 2 years ago

P.S.: The CTRL+Z undo is great. I need to think whether this could be moved into the base classes somehow, to make it easier/more generally accessible to all tools where undo makes sense. (E.g. it would make sense with the normal polygon tool and the "BetterPolygon" plugin. But not with the rectangle or circle tool.)

P.P.S.: I'm wondering whether there's a way to make the multipolygon tool more self-explanatory (at the moment you need to know about the 'N' shortcut) - and potentially touch friendly (where you have no keyboard). But it's a difficult design problem... probably nothing you can solve without some kind of context pop-up toolbar. I.e. it's great to have a working solution now, even if it isn't totally touch compatible. (In the long run: I'm already gathering ideas for "Annotorious 3" which would probably bring some more foundational changes to the drawing tool API, anyway.)