Fixing the starting point of the circle

annotorious / annotorious-v2-selector-pack

Additional selection tools for Annotorious and the Annotorious OpenSeadragon plugin

BSD 3-Clause "New" or "Revised" License

14 stars 20 forks source link

Fixing the starting point of the circle #9

Closed yyhhkk12 closed 3 years ago

yyhhkk12 commented 3 years ago

Annotorious version: standard Hello. I'm trying drawing circle annotation on image. When I drag the mouse to bottom right to draw a circle, starting point is fixed. But, other direction is not fixed. I want to fix the starting point. Could you make a fix mode?

rsimon commented 3 years ago

The circle tool is a 3rd party contribution. I'm not sure whether the original author is still listening in here. A pull request would be great in case you want to make an attempt at fixing it: the code that handles the drawing is in this file:

https://github.com/recogito/annotorious-selector-pack/blob/main/src/circle/RubberbandCircle.js

Specifically the dragTo method.

yyhhkk12 commented 3 years ago

I just sent a pull request(https://github.com/recogito/annotorious-selector-pack/pull/12). But, I don't know if it's right, so please review it.

rsimon commented 3 years ago

Wonderful - I reviewed, tested & just merged. Many thanks for the excellent fix!