search

anntzer / defopt

Effortless argument parser
https://pypi.org/project/defopt/
MIT License
213 stars 11 forks source link

add support for variable-length tuples and typing.Collection (#101) #103

Closed neelmraman closed 2 years ago

neelmraman commented 2 years ago

closes https://github.com/anntzer/defopt/issues/101

anntzer commented 2 years ago

Thanks, mostly looks good but a few things to fix.

anntzer commented 2 years ago

I allowed myself to push a few minor fixes to your branch directly. I also went back to getattr(collections.abc, 'Collection', object()) because the construct actually only appears twice, and this makes it less likely to be confused with typing.Collection.

anntzer commented 2 years ago

Thanks for the PR!