annuaire-entreprises-data-gouv-fr / site

Vérifiez les informations légales publiques des entreprises, associations et services publics en France
https://annuaire-entreprises.data.gouv.fr
MIT License
49 stars 15 forks source link

fix: association bilans and middleware coverage #1115

Closed XavierJp closed 2 months ago

XavierJp commented 2 months ago

Two tricky bugs :

First one

Caused by DJEPVA mutating siret from string to number. This PR add back open data bilan for association

second one

Due to next shortcoming. Middleware either apply to every request or you have to add a matcher. Problem : there is no easy matcher for appand pages. As a consequence, visit timestamp is not always set and antibot can get triggered. Not sure this currently happens in prod but this is bug prone.

I refactor a bit the middleware to avoid running the extract siren regex systematically and tried to come up with a more satisfying matcher.