Closed GoogleCodeExporter closed 8 years ago
All patchs are wellcome!
Original comment by jose.exposito89@gmail.com
on 1 Jan 2013 at 5:51
Done! Please see the attached patch, which should apply cleanly at the base of
the SVN repository.
My changes allow a "when" attribute to specified in actions, that can be either
AT_START or AT_END. For example:
<gesture type="DRAG" fingers="4" direction="UP">
<action type="CHANGE_DESKTOP" when="AT_START">NEXT</action>
</gesture>
In this example, the CHANGE_DESKTOP action will be triggered at the start of
the drag, instead of at the end as before.
This sort of feature really makes a difference when there are compiz-like
effects enabled. The screen appears to slide fluidly and smoothly to the next
desktop as soon as the fingers start moving on the touchpad, which feels great.
For actions that are a discrete event, being able to map them to the start/end
of the gesture is very nice in my humble opinion.
If a user doesn't specify any "when" attributes in the configuration file, the
code assumes "AT_END" by default (which is the original behavior). So, people
with unmodified configuration files shouldn't see any difference in behavior
when they update.
I modified the following actions to support this tag: CHANGE_DESKTOP,
CHANGE_VIEWPORT, CLOSE_WINDOW, MOUSE_CLICK, MINIMIZE_WINDOW,
MAXIMIZE_RESTORE_WINDOW, CLOSE_WINDOW, SHOW_DESKTOP, SEND_KEYS, and
RUN_COMMAND.
Please let me know what you think!
Cheers,
Steve
Original comment by sjlevin...@gmail.com
on 2 Jan 2013 at 10:47
Attachments:
Thank you very much, I'll test and commit it this weekend.
Thanks again for your work!!
Original comment by jose.exposito89@gmail.com
on 2 Jan 2013 at 10:48
My pleasure! Again, don't hesitate to let me know if you have any questions or
want me to make any changes.
Cheers,
Steve
Original comment by sjlevin...@gmail.com
on 3 Jan 2013 at 1:33
This patch is actually really cool, useful and working (at least for me) and I
was wondering, why you didn't commit it to the svn?
I had to manually patch it, at least.
Original comment by jannes.h...@gmail.com
on 23 Oct 2013 at 10:15
Yes, seems to work for me, too - and most non-continuous drag actions seem to
benefit greatly from this change. I'd go so far as to suggest making the
default timing to be at the start in future releases.
Original comment by thefishf...@gmail.com
on 15 Nov 2013 at 12:10
@sjlevine29 I'm so sorry for the big delay applying this patch, but I have just
committed it.
Thank you very much for your collaboration :D
Original comment by jose.exposito89@gmail.com
on 1 Dec 2013 at 12:48
Original issue reported on code.google.com by
sjlevin...@gmail.com
on 1 Jan 2013 at 2:58