search

anolilab / unplugin-favicons

Generate favicons for your project with caching for blazing fast rebuilds.
Other
4 stars 1 forks source link

Angular 18 config example request #44

Closed jonmarozick closed 2 months ago

jonmarozick commented 3 months ago

I'm trying to use this package to generate favicons in an Angular 18 application. I'm using the @angular-builders/custom-esbuild:application builder so I can add plugins into the esbuild system. I've looked at their examples but have had no luck.

The message I get is: An unhandled exception occurred: Package subpath './esbuild' is not defined by "exports" in C:\Projects\a18\esbuildtest\node_modules\@anolilab\unplugin-favicons\package.json

Here is a Stackblitz that shows the issue. Please forgive me if I've missed something simple.

Thanks.

github-actions[bot] commented 3 months ago

Awesome! Thank you for taking the time to create your first issue! Please review the guidelines

prisis commented 2 months ago

Hey, sorry i did see this notification, i will take a look asap

prisis commented 2 months ago

Hey @jonmarozick, added a example for angular without ts use of the esbuild, didnt find a example in the "@angular-builders/custom-esbuild" you can find it on ->

https://github.com/anolilab/unplugin-favicons/tree/main/examples/angular

jonmarozick commented 2 months ago

Thanks that worked!

jonmarozick commented 2 months ago

Is there a way to disable this warning?

[warn] [@anolilab/unplugin-favicons] html injection in esbuild is not supported, injection was disabled.
prisis commented 2 months ago

Currently not, should switch it maybe to debug

github-actions[bot] commented 1 month ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.