Improve governance - Githubissues

Fraccaman commented 2 years ago

Fix an overflow bug when computing voting power tally
Add validation of proposal .json when creating a new proposal
Fix a bug when computing total amount of nay/yay
Improving CLI UI

grarco commented 2 years ago

Also fixes anoma/namada#120

Fraccaman commented 2 years ago

pls update wasm

Fraccaman commented 2 years ago

pls restart ci

tzemanovic commented 2 years ago

I'm thinking we could maybe speed up the e2e proposal_submission test - in the setup (let test = setup::network(|genesis| genesis, None)?;), we could modify the genesis to have shorter min_proposal_period and min_proposal_grace_epochs

tzemanovic commented 2 years ago

In apps/src/lib/client/rpc.rs, the offline tally get_proposal_offline_votes is missing slashes for delegator's bonds. I think we need something like this: https://github.com/anoma/anoma/commit/dad75398b30539e2da8e15db970bdcc2e32ee094. I also refactored the last bit to update the maps with https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.entry

Ideally, this should really be hidden behind PoS API as the data from PoS is hard to query atm. I think we can solve it in future with some common interface for storage direct access and client RPC queries

tzemanovic commented 2 years ago

moved to https://github.com/anoma/namada/pull/262

anoma / anoma-archive

Improve governance #1111