Refactor ledger startup code

anoma / anoma-archive

Reference implementation of the Anoma protocols in Rust.

https://anoma.net

GNU General Public License v3.0

425 stars 176 forks source link

Refactor ledger startup code #1231

Closed sug0 closed 2 years ago

sug0 commented 2 years ago

I have broken down the run_aux function into several different logical units, which should make the ledger startup code more modular and easier to reason about.

This PR will help with the changes done to the eth bridge, since the latter will require even more startup logic code to manage geth. For the same reason, it is in conflict with #1196, so this will need to be handled.

sug0 commented 2 years ago

CI timed out :\

+ sccache --start-server
sccache: Starting the server...
sccache: error: Timed out waiting for server startup

tzemanovic commented 2 years ago

I tried to check the windows compilation, but unfortunately, we have a unix only dependency in the wallet file-lock, so it's not working atm. We don't officially support windows yet, so it's fine to go ahead - visually it seems fine to me :)

tzemanovic commented 2 years ago

if you could just pls add a changelog (https://github.com/anoma/anoma/blob/master/CONTRIBUTING.md#opening-a-pull-request)

sug0 commented 2 years ago

done! added a changelog entry

juped commented 2 years ago

Moved to anoma/namada#270 anoma/namada#271