Closed lukaszcz closed 2 weeks ago
I think we should have logs for when things are being cloned in the normal use-case. Perhaps we could configure the output based on the current log level instead to cover use cases where you don't want them printed?
I can turn back git messages. They go to stderr, so it's not really a problem. The main thing is redirecting the log
function to use stderr instead of stdout.
The problem for markdown generation is that the log goes to stdout. Do you have a reason to write it to stdout?
Ideally we would redirect the git messages to the Logger effect, probably on log level info or progress
But do we need the logger effect to then write it to stdout? If I just change this to stderr, this will already solve the markdown generation problem.
I mentioned the Logger effect, which prints to stderr, so that it integrates well with the existing cli flags
Juvix.Data.Effect.Log
writes to stdout, unless there is some other logger effect. Actually, I didn't change it, I only changed to stderr for the buffering
Changed to stderr now
Ah, okay, there is also Juvix.Data.Logger
. Maybe we should remove Juvix.Data.Effect.Log
then?
The "Cloning (...)" message was written to stdout which messed up markdown generation.