search

anoma / namada-interface

Apache License 2.0
79 stars 106 forks source link

Add notification for Shield/Unshield forms #1297

Open euharrison opened 4 days ago

euharrison commented 4 days ago

Currently, the MaspShield and MaspUnshield components are not displaying the notifications like the NamadaTransfer does.

But, on the other side, they are using the ShieldWorker and UnshieldWorker which is a good for performance.

We should unify these implementations so we can have the benefit of both.

In case we feel it'll be complex to use the worker, we could split this implementation into two PRs: 1 - Implement the notification on Shield/Unshield, it'll provide a better UX, and the worker is not so important right now 2 - Later, implement the worker that could be used by Shield/Unshield, but also for NamadaTransfer

euharrison commented 3 days ago

We should also review the timeline of the transaction so both use the same component <TransferTransactionTimeline>

Image