Closed jurevans closed 2 months ago
I've updated the UI slightly removing the Fee and memo from that design specific design
If we can get is as close to this as possible then great :)
Might need a horizontal scroll on each of the list items if we have to display a full address + a large amount or denomination of NAM
We need to re-introduce details about the Tx being signed in the Approval views.
PendingTx
tx
&signing
data as constructed bybuild
functions in the SDK. Is it possible to deserialize the Tx completely within the extension fromtx
solely?buildTx
functions, for simplicity's-sake. The TxType can be appended to the route used to invoke the approval, so we can use theenum
value, e.g.:/approve-sign-tx/1/....
where1
references the enum value, or/approve-sign-tx/transfer/...
The route could simply follow this structure:
Where
accountType
determines whether we use Extension key store, or Ledger HW Wallet, andtxType
tells us how to deserialize & display the Tx, andmsgId
gives us the key for thePendingTx
See Figma designs for Tx approvals: https://www.figma.com/design/NFyHbLZXBSl3aUsMxtffvV/Namada-End-User-Interface-V1.0-%2F-Phase-1%3A-Block-Party?node-id=4285-26253&t=k9h95cJpkjsPAh8e-0
Sign Arbitrary
We should handle "details" the same way when signing arbitrary data as well. We query the details for
signArbitrary
calls, which will always return a string. Then, attempt to parse the string as JSON, and format, something like:And display in a
<pre></pre>
per the designsFigma: https://www.figma.com/design/NFyHbLZXBSl3aUsMxtffvV/Namada-End-User-Interface-V1.0-%2F-Phase-1%3A-Block-Party?node-id=3968-2&t=da4IZ3LoUqFISuyV-0#812357271