Namadillo: Add proposals table pagination, fix pagination bugs - Githubissues

anoma / namada-interface

Apache License 2.0

77 stars 105 forks source link

Namadillo: Add proposals table pagination, fix pagination bugs #929

Closed emccorson closed 2 months ago

emccorson commented 3 months ago

Note for testing: Needs the latest version of namada-indexer including https://github.com/anoma/namada-indexer/pull/75.

Changed

Bump indexer to 0.0.17 to get the all proposals endpoint.
Refactor TableWithPaginator to not create its own pages. It now just receives pages of items and lets its parent handle creating pages.

Added

Add pagination to the All Proposals table.

Fixed

Fix proposal count by counting all proposals, not just one page of proposals. These numbers are shown on the right panel of the Governance page under "Total Proposals", "Proposals in Voting Period" etc.
Fetch all validators, not just the first page.

github-actions[bot] commented 3 months ago

🚀 Deployed on https://pull-request-929--wallet-development-heliax-dev.netlify.app

pedrorezende commented 2 months ago

This one also closes #916