Resolves #922
Resolves #923 (Indexer changes are merged!)
This PR updates the wasm checksum hashes for details to allow a client to optionally pass these to the signer in order to display details. Previously, these were added to the extension and persisted, however, this would allow a site to potentially update invalid hashes which would prevent details from displaying. As it's already the responsibility of the interface to query and provide these, I've moved them to the .sign() call invoked on the integration as an optional argument. If they are not provided, then the commitments within a batch will not deserialize, but signing will still work!
[x] Get checksums from indexer API in chain parameters
[x] Remove addTxWasmHashes & getTxWasmHashes from integration, along with all handling in extension
[x] Add checksums to PendingTx as optional prop, update messages accordingly
[x] Update namadillo to provide these checksums when signing - this means that the methods which invoke sign will need to pass along the checksums from the React components where the checksums value is accessed
github-actions[bot]
commented
1 month ago
Resolves #922 Resolves #923 (Indexer changes are merged!)
This PR updates the wasm checksum hashes for details to allow a client to optionally pass these to the signer in order to display details. Previously, these were added to the extension and persisted, however, this would allow a site to potentially update invalid hashes which would prevent details from displaying. As it's already the responsibility of the interface to query and provide these, I've moved them to the
.sign()call invoked on the integration as an optional argument. If they are not provided, then the commitments within a batch will not deserialize, but signing will still work!addTxWasmHashes&getTxWasmHashesfrom integration, along with all handling in extensionchecksumstoPendingTxas optional prop, update messages accordinglyNOTE the
sign()API is also changed here: https://github.com/anoma/namada-interface/pull/815, this removedtx_type&wrapper_tx_msg, the the max num of args ultimately will be 3