anoma / namada-interface

Apache License 2.0
77 stars 98 forks source link

Extension: Tx details - Denom consistency in details #946

Closed jurevans closed 1 month ago

jurevans commented 1 month ago

In the following example, this is how values are returned in Tx details in extension:

{
  "token": "tnam1qxgfw7myv4dh0qna4hq0xdg6lx77fzl7dcem8h7e",
  "feeAmount": "0.02",
  "gasLimit": "20000",
  "chainId": "local.7ffb17252ee474a7ea119ded",
  "commitments": [
    {
      "txType": "Bond",
      "hash": "970C160C67B0EB04CA1AE4CA08ADF13D018149DB6E7710D6B55D90E784B59716",
      "txCodeId": "d06fe5c3a271b70551730b9a9e76e6f57525a04f46c3ebc8a11197433f00ba1d",
      "memo": "",
      "source": "tnam1qz4sdx5jlh909j44uz46pf29ty0ztftfzc98s8dx",
      "validator": "tnam1q9vhfdur7gadtwx4r223agpal0fvlqhywylf2mzx",
      "amount": "123000000"
    }
  ]
}

Note that amount & gasLimit are returned in namnam, whereas feeAmount is returned in NAM - these should be consistent, and likely all represented as NAM