search

anoma / namada

Rust implementation of Namada, a Proof-of-Stake L1 for interchain asset-agnostic privacy
https://namada.net
GNU General Public License v3.0
2.38k stars 950 forks source link

showing which key we are inputting passphrase for while executing a transaction through CLI #2978

Open harish551 opened 3 months ago

harish551 commented 3 months ago

Currently CLI is not giving name or address of the account when asking for it's password, it will be difficult to enter passwords if we use different accounts for signing-keys and gas-payer

for better UX CLI should display which acconut it's taking password

example transaction:

cosmic@cv-namd-test:~$ namada client transfer --source new-ms --target tnam1qzpud3l936wzap09n3xmhh2yf7z2xpazhq745dm3 --token NAAN --amount 2 --memo "tpknam1qqn7a44k3nek9rpulrj9ey36yqctftnlplh6tzvlxwz2puhakq58zwvluvn" --signing-keys acc-new1,acc-new2,acc1  --gas-payer relayer
Enter your decryption password:
Enter your decryption password:
Enter your decryption password:
Error:
   0: unable to sign transaction with tpknam1qqc0934sc3akuv4ve6xk3mcpt24efxpjdcyjpfhpn6fzrxm0kdupvccu323

Location:
   /home/runner/work/namada/namada/crates/apps/src/lib/cli/client.rs:66

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
Rigorously commented 3 months ago

Duplicate of https://github.com/anoma/namada/issues/2513

McDaan commented 3 months ago

Duplicate of #2513

It's not fully a duplicate. You were referring to multisignature accounts - contrarily, this issue is referring and applies to all kind of situations.

harish551 commented 3 months ago

Duplicate of #2513

it's not fully duplicate, though I used multisig example we have this issue for every other transactions which require multiple signs from different accounts with different encryption passwords