anoma / namada

Rust implementation of Namada, a Proof-of-Stake L1 for interchain asset-agnostic privacy
https://namada.net
GNU General Public License v3.0
2.38k stars 950 forks source link

Cargo Udeps #3292

Open github-actions[bot] opened 1 month ago

github-actions[bot] commented 1 month ago

Unused dependencies

Crate Package Type
namada_vp_env 0.39.0 namada_ibc normal
brentstone commented 1 month ago

Not sure why flate2 and tar are detected as unused - they are used in fn namada_tests::integration::setup::initialize_genesis

Fraccaman commented 1 month ago

its not bulletproof, also we should update to cargo machete instead of cargo audit The report for cargo machete is actually more accurate I think:

cargo-machete found the following unused dependencies in .:
namada_vp_prelude -- ./crates/vp_prelude/Cargo.toml:
    thiserror
namada_apps_lib -- ./crates/apps_lib/Cargo.toml:
    linkme
    namada_test_utils
namada_gas -- ./crates/gas/Cargo.toml:
    linkme
namada_vm_env -- ./crates/vm_env/Cargo.toml:
    masp_primitives
namada_shielded_token -- ./crates/shielded_token/Cargo.toml:
    namada_tx
    smooth-operator
namada_core -- ./crates/core/Cargo.toml:
    linkme
    rand_core
namada -- ./crates/namada/Cargo.toml:
    bimap
    circular-queue
    data-encoding
    derivation-path
    derivative
    ethbridge-bridge-contract
    futures
    konst
    linkme
    masp_proofs
    namada_macros
    namada_migrations
    num-traits
    num256
    orion
    owo-colors
    paste
    rand_core
    regex
    serde
    slip10_ed25519
    smooth-operator
    tiny-bip39
    tiny-hderive
    toml
    wat
    zeroize
namada_merkle_tree -- ./crates/merkle_tree/Cargo.toml:
    linkme
namada_ethereum_bridge -- ./crates/ethereum_bridge/Cargo.toml:
    ethabi
    konst
    linkme
    rand
    serde_json
    tendermint
    tendermint-proto
namada_tests -- ./crates/tests/Cargo.toml:
    async-trait
    chrono
    lazy_static
    num-traits
    tracing
    tracing-subscriber
namada_proof_of_stake -- ./crates/proof_of_stake/Cargo.toml:
    data-encoding
    konst
    linkme
    num-traits
    smooth-operator
namada_state -- ./crates/state/Cargo.toml:
    arse-merkle-tree
    ics23
    linkme
    sha2
    smooth-operator
    tiny-keccak
namada_storage -- ./crates/storage/Cargo.toml:
    linkme
    serde
    smooth-operator
namada_tx -- ./crates/tx/Cargo.toml:
    konst
    linkme
namada_controller -- ./crates/controller/Cargo.toml:
    smooth-operator
namada_ibc -- ./crates/ibc/Cargo.toml:
    konst
    linkme
    namada_gas
    namada_tx
namada_tx_prelude -- ./crates/tx_prelude/Cargo.toml:
    sha2
    thiserror
namada_sdk -- ./crates/sdk/Cargo.toml:
    linkme
    smooth-operator
    tendermint-config
    tiny-bip39
namada_parameters -- ./crates/parameters/Cargo.toml:
    borsh
namada_governance -- ./crates/governance/Cargo.toml:
    konst
    linkme
    smooth-operator
namada_vp_env -- ./crates/vp_env/Cargo.toml:
    smooth-operator
    thiserror
namada_node -- ./crates/node/Cargo.toml:
    linkme
    smooth-operator
namada_account -- ./crates/account/Cargo.toml:
    linkme
namada_events -- ./crates/events/Cargo.toml:
    linkme
namada_apps -- ./crates/apps/Cargo.toml:
    bytes
    warp
    zeroize
namada_vote_ext -- ./crates/vote_ext/Cargo.toml:
    linkme
namada_trans_token -- ./crates/trans_token/Cargo.toml:
    konst
    linkme
tx_reactivate_validator -- ./wasm/tx_reactivate_validator/Cargo.toml:
    getrandom
    wee_alloc
tx_become_validator -- ./wasm/tx_become_validator/Cargo.toml:
    getrandom
    wee_alloc
tx_transfer -- ./wasm/tx_transfer/Cargo.toml:
    getrandom
    wee_alloc
tx_init_account -- ./wasm/tx_init_account/Cargo.toml:
    getrandom
    wee_alloc
tx_vote_proposal -- ./wasm/tx_vote_proposal/Cargo.toml:
    getrandom
    wee_alloc
tx_change_consensus_key -- ./wasm/tx_change_consensus_key/Cargo.toml:
    getrandom
    wee_alloc
tx_bridge_pool -- ./wasm/tx_change_bridge_pool/Cargo.toml:
    getrandom
    wee_alloc
vp_user -- ./wasm/vp_user/Cargo.toml:
    getrandom
    wee_alloc
tx_update_steward_commission -- ./wasm/tx_update_steward_commission/Cargo.toml:
    getrandom
    wee_alloc
tx_unjail_validator -- ./wasm/tx_unjail_validator/Cargo.toml:
    getrandom
    wee_alloc
tx_claim_rewards -- ./wasm/tx_claim_rewards/Cargo.toml:
    getrandom
    wee_alloc
tx_change_validator_commission -- ./wasm/tx_change_validator_commission/Cargo.toml:
    getrandom
    wee_alloc
tx_withdraw -- ./wasm/tx_withdraw/Cargo.toml:
    getrandom
    wee_alloc
tx_init_proposal -- ./wasm/tx_init_proposal/Cargo.toml:
    getrandom
    wee_alloc
tx_unbond -- ./wasm/tx_unbond/Cargo.toml:
    getrandom
    wee_alloc
tx_change_validator_metadata -- ./wasm/tx_change_validator_metadata/Cargo.toml:
    getrandom
    wee_alloc
tx_redelegate -- ./wasm/tx_redelegate/Cargo.toml:
    getrandom
    wee_alloc
vp_implicit -- ./wasm/vp_implicit/Cargo.toml:
    getrandom
    wee_alloc
tx_ibc -- ./wasm/tx_ibc/Cargo.toml:
    getrandom
    wee_alloc
tx_resign_steward -- ./wasm/tx_resign_steward/Cargo.toml:
    getrandom
    wee_alloc
tx_bond -- ./wasm/tx_bond/Cargo.toml:
    getrandom
    wee_alloc
tx_update_account -- ./wasm/tx_update_account/Cargo.toml:
    getrandom
    wee_alloc
tx_reveal_pk -- ./wasm/tx_reveal_pk/Cargo.toml:
    getrandom
    wee_alloc
tx_deactivate_validator -- ./wasm/tx_deactivate_validator/Cargo.toml:
    getrandom
    wee_alloc
vp_read_storage_key -- ./wasm_for_tests/vp_read_storage_key/Cargo.toml:
    getrandom
    namada_test_utils
    namada_tx_prelude
    wee_alloc
tx_no_op -- ./wasm_for_tests/tx_no_op/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
tx_infinite_guest_gas -- ./wasm_for_tests/tx_infinite_guest_gas/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
vp_memory_limit -- ./wasm_for_tests/vp_memory_limit/Cargo.toml:
    getrandom
    namada_test_utils
    namada_tx_prelude
    wee_alloc
vp_always_true -- ./wasm_for_tests/vp_always_true/Cargo.toml:
    getrandom
    namada_test_utils
    namada_tx_prelude
    wee_alloc
tx_proposal_ibc_token_inflation -- ./wasm_for_tests/tx_proposal_ibc_token_inflation/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
vp_infinite_guest_gas -- ./wasm_for_tests/vp_infinite_guest_gas/Cargo.toml:
    getrandom
    namada_test_utils
    namada_tx_prelude
    wee_alloc
tx_memory_limit -- ./wasm_for_tests/tx_memory_limit/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
tx_infinite_host_gas -- ./wasm_for_tests/tx_infinite_host_gas/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
vp_infinite_host_gas -- ./wasm_for_tests/vp_infinite_host_gas/Cargo.toml:
    getrandom
    namada_test_utils
    wee_alloc
tx_proposal_masp_reward -- ./wasm_for_tests/tx_proposal_masp_reward/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
tx_proposal_code -- ./wasm_for_tests/tx_proposal_code/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
tx_read_storage_key -- ./wasm_for_tests/tx_read_storage_key/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
tx_invalid_data -- ./wasm_for_tests/tx_invalid_data/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
namada_wasm_for_tests -- ./wasm_for_tests/wasm_source/Cargo.toml:
    getrandom
    namada_test_utils
    namada_tx_prelude
    namada_vp_prelude
    wee_alloc
tx_fail -- ./wasm_for_tests/tx_fail/Cargo.toml:
    getrandom
    namada_test_utils
    namada_vp_prelude
    wee_alloc
tx_write -- ./wasm_for_tests/tx_write/Cargo.toml:
    getrandom
    namada_vp_prelude
    wee_alloc
vp_always_false -- ./wasm_for_tests/vp_always_false/Cargo.toml:
    getrandom
    namada_test_utils
    namada_tx_prelude
    wee_alloc
vp_eval -- ./wasm_for_tests/vp_eval/Cargo.toml:
    getrandom
    namada_test_utils
    wee_alloc
namada_examples -- ./examples/Cargo.toml:
    regex
brentstone commented 1 month ago

Not sure why flate2 and tar are detected as unused - they are used in fn namada_tests::integration::setup::initialize_genesis

Ah can move them to dev deps

brentstone commented 1 month ago

@Fraccaman Wow yeah cargo machete seems significantly better. You're right it is not perfect but most of the things here are truly unused. Thx!