anoma / vamp-ir

Vamp-IR is a proof-system-agnostic language for writing arithmetic circuits
https://anoma.github.io/VampIR-Book/
Apache License 2.0
156 stars 44 forks source link

`vamp-ir halo2 verify` exits with status 0 for invalid proofs #75

Closed tkerber closed 1 year ago

tkerber commented 1 year ago

I'd expect invalid proofs to output a non-zero status code to indicate an error. At least the halo2 backend will print the failure, but exit as if verification had been a success.

lopeetall commented 1 year ago

Good catch. We are also working to improve error reporting #80 and this dovetails nicely.